Hi Shubham, I have reviewed v28* and posted updated v29 versions of patches 0001 and 0002.
If you are OK with these changes, the next task would be to pg_indent them, then rebase the remaining patches (0003 etc.) and include those with the next patchset version. ////////// Patch v29-0001 changes: nit - Fixed typo in comments. nit - Removed an unnecessary format change for the unchanged send_relation_and_attrs declaration. ////////// Patch v29-0002 changes: 1. Made fixes to address Vignesh's review comments [1]. 2. Added the missing test cases for tab_gen_to_gen, and tab_alter. 3. Multiple other modifications include: nit - Renamed the test database /test/test_igc_true/ because 'test' was too vague. nit - This patch does not need to change most of the existing 'tab1' test. So we should not be reformating the existing test code for no reason. nit - I added a summary comment to describe the test combinations nit - The "Testcase end" comments were unnecessary and prone to error, so I removed them. nit - Change comments /incremental sync/incremental replication/ nit - Added XXX notes about copy_data=false. These are reminders for to change code in later TAP patches nit - Rearranged test steps so the publisher does not do incremental INSERT until all initial sync tests are done nit - Added initial sync tests even if copy_data=false. This is for completeness - these will be handled in a later TAP patch nit - The table names are self-explanatory, so some of the test "messages" were simplified ====== [1] https://www.postgresql.org/message-id/CALDaNm31LZQfeR8Vv1qNCOREGffvZbgGDrTp%3D3h%3DEHiHTEO2pQ%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
v29-0001-Enable-support-for-include_generated_columns-opt.patch
Description: Binary data
v29-0002-Tap-tests-for-generated-columns.patch
Description: Binary data
