Robert Haas <robertmh...@gmail.com> writes:
> On Wed, Mar 5, 2025 at 1:53 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>> I'm quite confused by the #include additions in auto_explain.c and
>> file_fdw.c, and I strongly object to the ones in explain_state.h.
>> Surely those are unnecessary?
> They are necessary but they should have been part of 0001.
Ah. I was mistakenly assuming that 0001 would compile on its own ;-)
> Because
> 0001 moves the definition of ExplainState to explain_state.h, files
> that need to access to the members of that structure now need to
> include that header file. As for the includes in explain_state.h, it
> needs definitions for DefElem, ParseState, and PlannedStmt.
Got it. So does that mean we can remove any #include's from explain.h
after moving the struct definition?
regards, tom lane
