Robert Haas <robertmh...@gmail.com> writes:
> On Fri, Mar 7, 2025 at 9:38 AM Peter Eisentraut <pe...@eisentraut.org> wrote:
>> Also, benign typedef redefinitions are a C11 feature. In practice, all
>> compilers currently in play support it, and the only problem you'll get
>> is from the buildfarm members that are explicitly set up to warn about
>> accidental C11 use. We could probably have a discussion about that, but
>> for this patch set, it's probably better to just deal with the status quo.
> Agreed. +1 for having a discussion at some point, though, because the
> effect of the current rules seems to be that you have to write "struct
> BananaSplit *" in a bunch of places instead of just 'BananaSplit *" to
> avoid redefining the typedef.
I'd be +1 if there's a way to allow that particular thing without
thereby opening the floodgates to every other C11 feature. I expect
not all of C11 is universal yet, so I think the buildfarm animals
that are using -std=gnu99 are mostly doing us a service. But yeah,
this particular thing is a pain in the rear.
regards, tom lane
