On Wed, Oct 08, 2025 at 09:41:30PM +0300, Aleksander Alekseev wrote: > The main problem here is that clangd is a language server, which means > I see errors reported by it when I open a particular file in a text > editor. To go manually over ~2500 .c/.h files we have and then see > what will break on CI because of an #ifdef (as it was with the patch > v1) doesn't strike me as a great idea :)
Why not use IWYU as recommended in src/tools/pginclude/README? I gave that a try and it didn't take very long for src/. > Alternatively we could prioritize ~100 .c files which can be checked > manually. Or we can make changes iteratively, as with patches v1/v2. Excluding system headers, I'm seeing 390 suggestions for all C files in src/, some of which I'd probably skip (e.g., snowball). That doesn't seem too bad to me. -- nathan
