On 2026-09-09 We 6:25 PM, Andrew Dunstan wrote:
Thanks for reviewing. I hope to have some proposals tomorrow for addressing these issues as well as those raised by Noah.
I have run out of time, energy and brain cells. I have some working patches, but a) they need a little polish and b) I think they are too invasive for consideration now. The major difference in actual code (as opposed to testing) is in how we deal with permissions. I spent quite a lot of time yesterday and today on that, and came to the conclusion that it needs to be reworked along these lines: we should allow the user to see the information the functions provide if and only if they can see it by directly selecting from the catalog. Code changes to implement this by directly running ACL checks on the relevant catalogs are straightforward but also substantial. My proposed changes to testing are also substantial, being both more efficient and providing better coverage, especially w.r.t pg_dump/all compatibility.
I therefore suggest that we revert for release 19, but not in master, and I will continue to polish the patches I mentioned and publish them in a few days.
I can make the revert happen in the next day or so. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
