On Tue, Sep 15, 2026 at 2:01 PM vignesh C <[email protected]> wrote:
>
> The attached v2 version patch has the changes for the same. This also
> addresses Hou's comments from [1].
>
Thanks for the patch. I tested it across object reporting, address
resolution and error paths, event triggers, and dependency reporting,
and did not find any functional issues.
A couple of observations:
1) object_address.sql:105-106
The DO block here runs all accepted object type strings through
pg_get_object_address(). It seems worth adding the new value here as
well:
('operator of access method'), ('function of access method'),
- ('publication namespace'), ('publication relation')
+ ('publication namespace'), ('publication relation'),
+ ('publication excluded relation')
LOOP
2. aclchl.c, dropcmds.c, event_trigger.c, seclabel.c :
case OBJECT_PUBLICATION_REL:
+ case OBJECT_PUBLICATION_EXCLUDED_REL:
The case labels in these places appear to be in alphabetical order.
Should we keep the new case in the same order as well? Not necessary,
but it would keep the existing ordering consistent.
--
Thanks,
Nisha
