On Wed, Sep 16, 2026 at 10:27 PM vignesh C <[email protected]> wrote: > > On Wed, 16 Sept 2026 at 14:26, vignesh C <[email protected]> wrote: > > > > On Wed, 16 Sept 2026 at 13:57, Chao Li <[email protected]> wrote: > > > > > > I don’t think the fix would add much complexity, please see the attached > > > diff I tried. This error message is shown to users, so I think improving > > > it is worthwhile. > > > > Agreed. I had initially thought the additional code complexity was not > > worthwhile. Since this is a user-facing error message, I agree that > > making it more specific is worthwhile. Thanks, I have merged the > > changes. > > The attached v5 version patch has the changes for the same. > > While reviewing the patch further, I noticed that the Assert in > get_object_address_publication_rel() can be placed immediately after > the variable declarations, rather than after the subsequent checks. > The attached v6 patch includes this change. >
v6 LGTM. thanks Shveta
