On Tue, Jan 15, 2019 at 6:05 PM Andres Freund <and...@anarazel.de> wrote:
> Hi, > > On 2019-01-15 18:02:38 +1100, Haribabu Kommi wrote: > > On Tue, Dec 11, 2018 at 1:13 PM Andres Freund <and...@anarazel.de> > wrote: > > > > > Hi, > > > > > > On 2018-11-26 17:55:57 -0800, Andres Freund wrote: > > > Further tasks I'm not yet planning to tackle, that I'd welcome help on: > > > - pg_upgrade testing > > > > > > > I did the pg_upgrade testing from older version with some tables and > views > > exists, and all of them are properly transformed into new server with > heap > > as the default access method. > > > > I will add the dimitry pg_dump patch and test the pg_upgrade to confirm > > the proper access method is retained on the upgraded database. > > > > > > > > > - I think we should consider removing HeapTuple->t_tableOid, it should > > > imo live entirely in the slot > > > > > > > I removed the t_tableOid from HeapTuple and during testing I found some > > problems with triggers, will post the patch once it is fixed. > > > Please note that I'm working on a heavily revised version of the patch > right now, trying to clean up a lot of things (you might have seen some > of the threads I started). I hope to post it ~Thursday. Local-ish > patches shouldn't be a problem though. > Yes, I am checking you other threads of refactoring and cleanups. I will rebase this patch once the revised code is available. I am not able to remove the complete t_tableOid from HeapTuple, because of its use in triggers, as the slot is not available in triggers and I need to store the tableOid also as part of the tuple. Currently setting of t_tableOid is done only when the tuple is formed from the slot, and it is use is replaced with slot member. comments? Regards, Haribabu Kommi Fujitsu Australia
0001-Reduce-the-use-of-HeapTuple-t_tableOid.patch
Description: Binary data
