On Mon, Jul 08, 2019 at 03:21:41PM -0400, Tom Lane wrote: > Having said that, join_hash.sql in particular seems to have zero > value if it's not testing hash joins, so I think it'd be reasonable > for it to override a global enable_hashjoin = off setting. None of > the other regression test scripts seem to take nearly as much of a > performance hit from globally forcing poor plans.
I am a bit confused here. Don't you mean to have enable_hashjoin = *on* at the top of hash_join.sql instead like in the attached? -- Michael
diff --git a/src/test/regress/expected/join_hash.out b/src/test/regress/expected/join_hash.out index 9eee39bdd3..0890608acf 100644 --- a/src/test/regress/expected/join_hash.out +++ b/src/test/regress/expected/join_hash.out @@ -1,6 +1,9 @@ -- -- exercises for the hash join code -- +-- Enforce the use of hash joins in this test, which could get disabled +-- at system-level. +set enable_hashjoin = on; begin; set local min_parallel_table_scan_size = 0; set local parallel_setup_cost = 0; diff --git a/src/test/regress/sql/join_hash.sql b/src/test/regress/sql/join_hash.sql index ae352e9b0b..b38081d1d5 100644 --- a/src/test/regress/sql/join_hash.sql +++ b/src/test/regress/sql/join_hash.sql @@ -2,6 +2,10 @@ -- exercises for the hash join code -- +-- Enforce the use of hash joins in this test, which could get disabled +-- at system-level. +set enable_hashjoin = on; + begin; set local min_parallel_table_scan_size = 0;
signature.asc
Description: PGP signature
