On Tue, Jul 9, 2019 at 2:22 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@gmail.com> writes: > > Based on a suggestion from Andres (if I recall correctly), I wrapped > > each individual test in savepoint/rollback, and then set just the GUCs > > needed to get the plan shape and execution code path I wanted to > > exercise, and I guess I found that I only needed to disable merge > > joins for some of them. The idea was that the individual tests could > > be understood independently. > > But per this discussion, they can only be "understood independently" > if you make some assumptions about the prevailing values of the > planner GUCs.
Yeah. I had obviously never noticed that test script. +1 for just enabling hash joins the top of join_hash.sql in 12+, and the equivalent section in 11's join.sql (which is luckily at the end of the file). -- Thomas Munro https://enterprisedb.com
