Michael Paquier <mich...@paquier.xyz> writes: > On Mon, Jul 08, 2019 at 03:21:41PM -0400, Tom Lane wrote: >> Having said that, join_hash.sql in particular seems to have zero >> value if it's not testing hash joins, so I think it'd be reasonable >> for it to override a global enable_hashjoin = off setting. None of >> the other regression test scripts seem to take nearly as much of a >> performance hit from globally forcing poor plans.
> I am a bit confused here. Don't you mean to have enable_hashjoin = > *on* at the top of hash_join.sql instead like in the attached? Right, overriding any enable_hashjoin = off that might've come from PGOPTIONS or wherever. regards, tom lane