On Sat, Apr 18, 2020 at 6:16 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Fri, Apr 17, 2020 at 6:45 PM Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: > > > > On 2020-04-14 05:57, Amit Kapila wrote: > > > Peter E, others, any suggestions on how to move forward? I think here > > > we should follow the rule "follow the style of nearby code" which in > > > this case would be to have one space after each field as we would like > > > it to be closer to the "Buffers" format. It would be good if we have > > > a unified format among all Explain stuff but we might not want to > > > change the existing things and even if we want to do that it might be > > > a broader/bigger change and we should do that as a PG14 change. What > > > do you think? > > > > If looks like shortening to fpw= and using one space is the easiest way > > to solve this issue. > > > > I am fine with this approach and will change accordingly. I will wait > for a few days (3-4 days) to see if someone shows up with either an > objection to this or with a better idea for the display of WAL usage > information.
That was also my preferred alternative. PFA a patch for that. I also changed to "fpw" for the non textual output for consistency.
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c index 7ae6131676..9cc1b13b76 100644 --- a/src/backend/commands/explain.c +++ b/src/backend/commands/explain.c @@ -3350,13 +3350,13 @@ show_wal_usage(ExplainState *es, const WalUsage *usage) appendStringInfoString(es->str, "WAL:"); if (usage->wal_records > 0) - appendStringInfo(es->str, " records=%ld", + appendStringInfo(es->str, " records=%ld", usage->wal_records); if (usage->wal_fpw > 0) - appendStringInfo(es->str, " full page writes=%ld", + appendStringInfo(es->str, " fpw=%ld", usage->wal_fpw); if (usage->wal_bytes > 0) - appendStringInfo(es->str, " bytes=" UINT64_FORMAT, + appendStringInfo(es->str, " bytes=" UINT64_FORMAT, usage->wal_bytes); appendStringInfoChar(es->str, '\n'); } @@ -3365,7 +3365,7 @@ show_wal_usage(ExplainState *es, const WalUsage *usage) { ExplainPropertyInteger("WAL records", NULL, usage->wal_records, es); - ExplainPropertyInteger("WAL full page writes", NULL, + ExplainPropertyInteger("WAL fpw", NULL, usage->wal_fpw, es); ExplainPropertyUInteger("WAL bytes", NULL, usage->wal_bytes, es);