On Sat, Oct 31, 2020 at 9:04 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > > +$node->append_conf('postgresql.conf', "logging_collector= 'on'"); > > +$node->append_conf('postgresql.conf', "log_connections= 'on'"); > > > > booleans don't need quotes. > > > > I think that's not correct. If I'm right, the snippet pointed above is > from a perl script. In C, the strings are null terminated and they are > represented within double quotes. So we need to use double quotes for > _("on") : _("off"). And also the definition of _( ) macro points to a > function err_gettext() that expects C-style string i.e null > terminated. >
I'm sorry for the above point, I misunderstood it. I took a further look at the patch. It seems like it's a mix. In some place we are not using quotes for booleans, for instance, $node->append_conf('postgresql.conf', 'autovacuum=off'); $node->append_conf('postgresql.conf', 'track_commit_timestamp = on'); but in one place we are using quotes $node->append_conf('postgresql.conf', "ssl = 'on'"); Either way seems to be fine as we don't have any variables inside the strings to be replaced by the perl interpreter. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com