On Tue, Nov 3, 2020 at 12:49 PM vignesh C <vignes...@gmail.com> wrote: > > Thanks for the explanation, I have attached a v5 patch with the > changes where the translation should not have any problem. >
I took a look at the V5 patch. Below are some comments: 1. Do we need to generate and add the translation of the new GSS message in all the language specific files under po/ directory?. See below for the translated SSL log message added in all the language specific .po files. [1] may help. I'm not quite sure whether translation should be part of the patch or is it done separately? Say someone doing tralsations for a bunch of log messages together in a single commit? #: utils/init/postinit.c:237 #, c-format msgid "replication connection authorized: user=%s SSL enabled (protocol=%s, cipher=%s, compression=%s)" msgstr "conexão de replicação autorizada: usuário=%s SSL habilitado (protocolo=%s, cifra=%s, compressão=%s)" 2. I have one concern about the test case, where we look for an expected message[2](in English language), but what happens if the logging collector collects the log messages in a different language, say[3]? Will the test case fail? I saw that in 004_logrotate.pl we look for "division by zero" in the logs, will the same concern apply to this as well? [1] - https://www.postgresql.org/docs/current/nls-translator.html [2] - "connection authorized: user=$username database=$dbname application_name=$application [3] - "conexão autorizada: usuário=%s banco de dados=%s SSL habilitado (protocolo=%s, cifra=%s, compressão=%s)" With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
