Hi Justin,

On 2021/01/18 1:52, Justin Pryzby wrote:
On Sun, Jan 17, 2021 at 03:31:57PM +0100, Tomas Vondra wrote:
I've reverted the commit - once we find the right way to handle this, I'll
get it committed again.

Please consider these doc changes for the next iteration.

commit 1a69f648ce6c63ebb37b6d8ec7c6539b3cb70787
Author: Justin Pryzby <pryz...@telsasoft.com>
Date:   Sat Jan 16 17:47:35 2021 -0600

     doc review: psql \dX 891a1d0bca262ca78564e0fea1eaa5ae544ea5ee

Thanks for your comments!
It helps a lot since I'm not a native speaker.
I'll fix the document based on your suggestion on the next patch.

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index aaf55df921..a678a69dfb 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1928,15 +1928,15 @@ testdb=&gt;
          is specified, only those extended statistics whose names match the
          pattern are listed.
          If <literal>+</literal> is appended to the command name, each extended
-        statistics is listed with its size.
+        statistic is listed with its size.

Agreed.

          <para>
-        The column of the kind of extended stats (e.g. Ndistinct) shows some 
statuses.
+        The column of the kind of extended stats (e.g. Ndistinct) shows its 
status.
          "requested" means that it needs to collect statistics by <link
          linkend="sql-analyze"><command>ANALYZE</command></link>.
          "built" means <link 
linkend="sql-analyze"><command>ANALYZE</command></link> was

Agreed.


-        finished, and the planner can use it. NULL means that it doesn't 
exists.
+        run, and statistics are available to the planner. NULL means that it 
doesn't exist.


Agreed.


Thanks,
Tatsuro Yamada



Reply via email to