út 9. 3. 2021 v 6:34 odesílatel Michael Paquier <mich...@paquier.xyz> napsal: > > On Mon, Mar 08, 2021 at 05:33:40PM +0100, Matthias van de Meent wrote: > > Seems reasonable. PFA updated patches. I've renamed the previous 0003 > > to 0002 to keep git-format-patch easy. > > Thanks for updating the patch. 0001 has been applied, after tweaking > a bit comments, indentation and the docs. > > > This is keeping current behaviour of the implementation as committed > > with 8a4f618e, with the rationale of that patch being that this number > > should mirror the number returned by the copy command. > > > > I am not opposed to adding another column for `tuples_inserted` and > > changing the logic accordingly (see prototype 0003), but that was not > > in the intended scope of this patchset. Unless you think that this > > should be included in this current patchset, I'll spin that patch out > > into a different thread, but I'm not sure that would make it into > > pg14. > > Okay, point taken. If there is demand for it in the future, we could > extend the existing set of columns. After thinking more about it the > usecase if not completely clear to me from a monitoring point of > view. > > I have not looked at 0002 in details yet, but I am wondering first if > the size estimations in the expected output are actually portable. > Second, I doubt a bit that the extra cycles spent on that are actually > worth the coverage, even if the trick with an AFTER INSERT trigger is > interesting.
Those extra cycles are in there to cover at least parts of the COPY progress from being accidentally broken. I have seen various patches modifying COPY command being currently in progress. It would be nice to ensure at least basic functionality works well in an automated way. On my machine there is no huge overhead added by adding those tests (they finish almost instantly). > -- > Michael
