> On Mar 11, 2021, at 12:12 AM, Peter Eisentraut
> <peter.eisentr...@enterprisedb.com> wrote:
>
> (I'm still not a fan of adding more client-side tools whose sole task is to
> execute server-side functionality in a slightly filtered way, but it seems
> people are really interested in this, so ...)
>
> I want to register, if we are going to add this, it ought to be in src/bin/.
> If we think it's a useful tool, it should be there with all the other useful
> tools.
I considered putting it in src/bin/scripts where reindexdb and vacuumdb also
live. It seems most similar to those two tools.
> I realize there is a dependency on a module in contrib, and it's probably now
> not the time to re-debate reorganizing contrib. But if we ever get to that,
> this program should be the prime example why the current organization is
> problematic, and we should be prepared to make the necessary moves then.
Before settling on contrib/pg_amcheck as the location, I checked whether any
tools under src/bin had dependencies on a contrib module, and couldn't find any
current examples. (There seems to have been one in the past, though I forget
which that was at the moment.)
I have no argument with changing the location of this tool before it gets
committed, but I wonder if we should do that now, or wait until some future
time when contrib gets reorganized? I can't quite tell which you prefer from
your comments above.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
