Andrew Dunstan wrote:


David Fetter wrote:

Maybe we should fix our C sample trigger, from which this was taken.

Yes :)

Does the attached have the right error code?

-        elog(ERROR, "trigf: not called by trigger manager");
+        ereport(ERROR,
+                (error(TRIGGERED_DATA_CHANGE_VIOLATION),
+                 errmsg("trigf: not called by trigger manager")));


Not sure that's appropriate, but I can't see anything else that is very appropriate either.


The plpgsql code uses errcode(ERRCODE_FEATURE_NOT_SUPPORTED) for this situation, so I guess we should be consistent with that.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to