On Mon, Feb 1, 2010 at 1:31 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> I have cleaned up and simplified this patch. Attached is the version >> I intend to commit. Changes: > > Minor suggestions: > > I think the names like "rel_parents" would read better as > "rel_numparents" etc. As-is, the reader could be forgiven for expecting > that this will be a list of parent relation OIDs or some such.
I thought about that but ended up being lazy and leaving it the way I had it. I'll go be un-lazy. > The new loop added within find_all_inheritors could really do with an > addition to the comments, along the line of "If a child is already > seen, increment the corresponding numparents count". OK. > I don't trust the proposed "order by attrelid" business in the > regression test --- once in a blue moon, that will fail because the > OID counter wrapped around mid-test, and we'll get an unreproducible > bug report. I'd suggest order by attrelid::regclass::text. Wow, didn't think of that. Will change. > Looks sane otherwise. Thanks for the review. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
