(2010/02/02 11:09), Tom Lane wrote: > KaiGai Kohei<kai...@ak.jp.nec.com> writes: >> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code, >> not only ATPrepAlterColumnType(), according to what I mentioned above. > > What exactly do you claim is wrong with the ADD COLUMN case?
ADD COLUMN case works correctly, but it takes unnecessary loops, because the find_all_inheritors() didn't provide the value to be set on the new pg_attribute.attinhcount. I'm saying it can be rewritten in more graceful manner using the new expected_parents argument. Thanks, -- OSS Platform Development Division, NEC KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
