KaiGai Kohei <kai...@ak.jp.nec.com> writes: > (2010/02/02 11:09), Tom Lane wrote: >> KaiGai Kohei<kai...@ak.jp.nec.com> writes: >>> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code, >>> not only ATPrepAlterColumnType(), according to what I mentioned above. >> >> What exactly do you claim is wrong with the ADD COLUMN case?
> ADD COLUMN case works correctly, but it takes unnecessary loops, > because the find_all_inheritors() didn't provide the value to be > set on the new pg_attribute.attinhcount. > I'm saying it can be rewritten in more graceful manner using the > new expected_parents argument. I tend to think that if it ain't broke don't fix it; the odds of actually breaking it are too high. I don't really find the new coding more graceful, anyway ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers