(2010/02/02 23:50), Robert Haas wrote: > 2010/2/1 KaiGai Kohei<kai...@ak.jp.nec.com>: >>> I'm making a general statement - if something is BROKEN (like the >>> rename case we just dealt with), we should look at fixing it. If it's >>> just something that could be cleaned up or done more nicely, we should >>> leave it alone for now. >> >> OK, Please forget the second patch. >> >> The former patch (pgsql-fix-inherit-attype.1.patch) just fixes the matter >> in ALTER COLUMN TYPE case. Do you think it is a reasonable change for >> the 9.0 release? > > After reviewing this, I see that it doesn't really make sense to fix > ALTER COLUMN TYPE without rewriting ADD COLUMN to use > ATSimpleRecursion(). If we're going to go to the trouble of > refactoring the ATPrepCmd() interface, we certainly want to get as > much benefit out of that as we can. > > That having been said... I'm leery about undertaking a substantial > refactoring of this code at this point in the release cycle. We have > less than two weeks remaining before the end of the final CommitFest, > so it doesn't seem like a good time to be starting new projects, > especially because we still have 16 patches that need we need to grind > through in less than 2 weeks, and I want to give some of those my > attention, too. So I would like to push this out to 9.1 and revisit > it when I can give it the amount of time that I believe is needed to > do it right.
OK, I'll work on remained part of this fix in the v9.1. Thanks, -- OSS Platform Development Division, NEC KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers