On Wed, Feb 3, 2010 at 11:18 AM, Marko Tiikkaja <marko.tiikk...@cs.helsinki.fi> wrote: > On 2010-02-03 16:53 UTC+2, Robert Haas wrote: >> Some thoughts: >> >> The comments in standard_ExecutorStart() don't do a good job of >> explaining WHY the code does what it does - they just recapitulate >> what you can already see from reading the code. You say "If there are >> DML WITH statements, we always need to use the CID and copy the >> snapshot." That's self-evident from the following code. What's not >> clear is why this is necessary, and the comment doesn't make any >> attempt to explain it. The second half of the if statement has the >> same problem. > > > Right. The documentation in its current state is definitely lacking. > I've tried to focus all the time I have in making this patch technically > good.
Outside of documentation issues, where do we stand? Do you need help with the documentation? merlin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
