On Sun, Aug 8, 2010 at 11:36 AM, Mike Fowler <m...@mlfowler.com> wrote: > On 06/08/10 17:50, Pavel Stehule wrote: >> attached updated patch with regression test > > Bravely ignoring the quotation/varidic/<favourite_scheme_here> > conversations,
Thank you! > I've taken a look at the patch as is. Excellent. > Thanks to Tom's input I > can now correctly drive the function. I can also report that code is now > behaving in the expected way. > > I have two other observations, more directed at the community than Pavel: > > 1) XML2 is largely undocumented, giving rise to the problems encountered. > Since the module is deprecated anyways, does it make more sense to get xslt > handling moved into core and get it fully documented? Yes, I think that would be better. > 2) Pavel's regression test exposes a bug in libxslt. The stylesheet declares > 5 parameters, but uses 12. Simplifying, take the stylesheet: I'm not sure whether there's anything we can do about this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
