On Thu, Aug 12, 2010 at 09:53:54AM -0700, Joshua D. Drake wrote: > On Thu, 2010-08-12 at 09:44 -0700, David Fetter wrote: > > On Thu, Aug 12, 2010 at 12:27:45PM -0400, Tom Lane wrote: > > > Robert Haas <robertmh...@gmail.com> writes: > > > > Here's an updated patch, with the invalidation changes merged > > > > in and hopefully-suitable adjustments elsewhere. > > > > > > I haven't tested this patch, but I read through it (and have I > > > mentioned how unbelievably illegible -u format patches are?). > > > > I have every confidence that you, of all people, can arrange to > > use 'filterdiff --format=context' on attached patches > > automatically, saving you some time and us some boredom :) > > I was under the impression that the project guideline was that we > only accepted context diffs?
Since they're trivially producible from unified diffs, this is a pretty silly reason to bounce--or even comment on--patches. It's less a guideline than a personal preference, namely Tom's. Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
