On Fri, Aug 13, 2010 at 12:49 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Here is an updated patch. It's in context-diff format this time, > > Thanks, I appreciate that ;-) > > This looks committable to me, with a couple of tiny suggestions:
Woo hoo! > In the text added to storage.sgml, s/temporary relation/temporary relations/. > Also, it'd be better if BBB and FFF were marked up as <replaceable> > rather than <literal>, see examples elsewhere in that file. I see. How should I mark tBBB_FFF? I actually didn't like that way of explaining it very much, but I couldn't think of anything clearer. Saying "the name will consist of a lowercase t, followed by the backend ID, followed by an underscore, followed by the filenode" did not seem better. > The comment for local_buffer_write_error_callback() probably meant to > say "during local buffer writes". No doubt. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
