On Mon, Nov 29, 2010 at 10:37 AM, Andrew Dunstan <and...@dunslane.net> wrote: > > > On 11/29/2010 10:30 AM, Robert Haas wrote: >> >> On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas<robertmh...@gmail.com> >> wrote: >>> >>> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine >>> <dimi...@2ndquadrant.fr> wrote: >>>>> >>>>> * I'd like to ask native speakers whether "from" is needed in names >>>>> of "pg_execute_from_file" and "pg_execute_from_query_string". >>>> >>>> Fair enough, will wait for some comments before producing a v6. >>> >>> Yes, you need the from there. >> >> Eh, wait. You definitely need from in pg_execute_from_file(). But >> pg_execute_from_query_string() doesn't sound quite right. What does >> that function do, anyway? > > I'm not sure why you need either "from". It just seems like a noise word. > Maybe we could use pg_execute_query_file() and pg_execute_query_string(), > which would be fairly clear and nicely symmetrical.
Because you execute queries, not files. Or at least that's how I think about it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
