Good question, I hadn't thought of that either, and thinking about it a bit
I think we'd want to keep the current behaviour of \i and provide new
behaviour using a new command.

Say when we are processing a pretty nested file after multiple \ir commands,
a \i <relative path file> in any of those files should look for that file in
psql's CWD/PWD. That is what the user expects from \i command currently and
I don't think it'd be desirable to break that assumption.

Regards,

On Wed, Mar 9, 2011 at 4:41 PM, David Fetter <da...@fetter.org> wrote:

> Being able to include relative paths is a really great feature, but
> should it have a UI (well, API) distinct from fixed-path includes?  My
> first instinct is that it shouldn't, but I haven't really thought it
> through thoroughly.
>
> Cheers,
> David (the tough coughs as he ploughs the dough)
> On Tue, Mar 08, 2011 at 03:19:40PM -0500, Gurjeet Singh wrote:
> > Attached patch implements tab completion. It also introduces the
> long-form
> > alternative \include_relative for \ir
> >
> > Regards,
> >
> > On Tue, Mar 8, 2011 at 2:18 PM, Ibrar Ahmed <ibrar.ah...@gmail.com>
> wrote:
> >
> > > Gurjeet!
> > >
> > > What about tab completion, like in \i command?
> > >
> > > On Fri, Feb 25, 2011 at 5:07 AM, Robert Haas <robertmh...@gmail.com>
> > > wrote:
> > > > On Thu, Feb 24, 2011 at 6:21 PM, Gurjeet Singh <
> singh.gurj...@gmail.com>
> > > wrote:
> > > >>     psql has the ability to execute commands from a file, but if one
> > > wishes
> > > >> to develop and provide a modularized set of sql files, then psql is
> not
> > > very
> > > >> helpful because the \i command can open file paths either if they
> are
> > > >> absolute paths or if they are palced correctly relative to psql's
> > > current
> > > >> working directory.
> > > >>
> > > >> Attached patch adds a new meta-command to psql, '\ir' that allows
> the
> > > user
> > > >> to process files relative to currently processing file.
> > > >
> > > > Please add this patch to the currently open CommitFest at:
> > > >
> > > > https://commitfest.postgresql.org/action/commitfest_view/open
> > > >
> > > > --
> > > > Robert Haas
> > > > EnterpriseDB: http://www.enterprisedb.com
> > > > The Enterprise PostgreSQL Company
> > > >
> > > > --
> > > > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> > > > To make changes to your subscription:
> > > > http://www.postgresql.org/mailpref/pgsql-hackers
> > > >
> > >
> > >
> > >
> > > --
> > >    Ibrar Ahmed
> > >
> >
> >
> >
> > --
> > Gurjeet Singh
> > EnterpriseDB <http://www.enterprisedb.com/> Corporation
> > The Enterprise PostgreSQL <http://www.postgresql.org/> Company
>
>
> >
> > --
> > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-hackers
>
>
> --
> David Fetter <da...@fetter.org> http://fetter.org/
> Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
> Skype: davidfetter      XMPP: david.fet...@gmail.com
> iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
>
> Remember to vote!
> Consider donating to Postgres: http://www.postgresql.org/about/donate
>



-- 
Gurjeet Singh
EnterpriseDB <http://www.enterprisedb.com/> Corporation
The Enterprise PostgreSQL <http://www.postgresql.org/> Company

Reply via email to