On Wed, Oct 5, 2011 at 4:47 AM, Kohei KaiGai <kai...@kaigai.gr.jp> wrote: > The get_relation_address() follows the logic in RemoveRelations() to be > eliminated by this patch, so it is not a code duplication. > The reason why we didn't consolidate this routine with get_object_address() > was that remove-index requires locks on the table which owns the index to > be removed, and it was ugly to add an ad-hoc if-block on the routine.
Yeah, that's a problem that's been in the back of my mind for a bit now, but I haven't come up with a good solution. I don't think RemoveRelations() is the only place we have this problem, either. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
