On Tue, Nov 20, 2012 at 3:02 AM, Tomas Vondra <t...@fuzzy.cz> wrote: > 2) It's common to use upper-case names for macros, but trgm.h defines > macro "iswordchr" - I see it's moved from trgm_op.c but maybe we > could make it a bit more correct? > > 3) I see there are two '#ifdef KEEPONLYALNUM" blocks right next to each > other in trgm.h - maybe it'd be a good idea to join them? > > 4) The two new method prototypes at the end of trgm.h use different > indendation than the rest (spaces only instead of tabs). > These issues are fixed in attached patch. Additionally 3 new macros are introduced: MAX_RESULT_STATES, MAX_RESULT_ARCS, MAX_RESULT_PATHS. They are limiting resources usage during regex processing.
------ With best regards, Alexander Korotkov.
trgm-regexp-0.4.patch.gz
Description: GNU Zip compressed data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
