On Thursday, December 20, 2012 7:03 PM Simon Riggs wrote: > On 20 December 2012 13:19, Amit Kapila <amit.kap...@huawei.com> wrote: > > >> So I think we're good on that front. But I'll add a comment there, > and > >> use 0 explicitly instead of ThisTimeLineID, for clarity. > > > > True, it might not have any functionality effect in > RemoveOldXlogFiles(). > > However it can be used in PreallocXlogFiles()->XLogFileInit() as > well. > > PreallocXlogFiles() should have been put to the sword long ago. It's a > performance tweak aimed at people without a performance problem in > this area.
Yes, it seems to be for a rare scenario. > I'll happily accept this excuse to remove it. > > We can discuss whether any replacement is required. We should think of alternatives if there is no other reasonable fix for the problem. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
