On 2012-12-20 16:46:21 +0000, Simon Riggs wrote: > On 20 December 2012 13:19, Amit Kapila <amit.kap...@huawei.com> wrote: > > > True, it might not have any functionality effect in RemoveOldXlogFiles(). > > However it can be used in PreallocXlogFiles()->XLogFileInit() as well. > > Which is never called in recovery because we never write WAL.
It's called from CreateRestartPoint. And the pre-inited files get used by the walreceiver and I would guess thats beneficial at elast for sync rep... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers