On Fri, Sep 28, 2012 at 12:40:38PM -0500, Karl O. Pinc wrote:
> Hi,
> 
> The attached patch (against git head)
> normalizes "search_path" as the thing indexed
> and uses a secondary index term to distinguish
> the configuration parameter from the run-time
> setting.
> 
> "search path" the concept remains distinguished
> in the index from "search_path" the setting/config param.
> It's hard to say whether it's useful to make this
> distinction.  From a practical perspective it's easy
> for the eye to stop scanning when the indent
> level changes and so fail to notice that both
> "search path" and "search_path" are index
> entries.  At least the index is a 
> lot more tidy than before.

I have applied a modified version of your patch that creates separate
secondary index references for search_path.

-- 
  Bruce Momjian  <br...@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
new file mode 100644
index b7df8ce..5f47c1f
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
*************** COPY postgres_log FROM '/full/path/to/lo
*** 4778,4784 ****
       <varlistentry id="guc-search-path" xreflabel="search_path">
        <term><varname>search_path</varname> (<type>string</type>)</term>
        <indexterm>
!        <primary><varname>search_path</> configuration parameter</primary>
        </indexterm>
        <indexterm><primary>path</><secondary>for schemas</></>
        <listitem>
--- 4778,4785 ----
       <varlistentry id="guc-search-path" xreflabel="search_path">
        <term><varname>search_path</varname> (<type>string</type>)</term>
        <indexterm>
!        <primary><varname>search_path</></primary>
!        <secondary>configuration parameter</secondary>
        </indexterm>
        <indexterm><primary>path</><secondary>for schemas</></>
        <listitem>
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
new file mode 100644
index 207de9b..929d29c
*** a/doc/src/sgml/ddl.sgml
--- b/doc/src/sgml/ddl.sgml
*************** CREATE TABLE public.products ( ... );
*** 1735,1741 ****
     </para>
  
     <indexterm>
!     <primary><varname>search_path</varname> configuration parameter</primary>
     </indexterm>
  
     <para>
--- 1735,1742 ----
     </para>
  
     <indexterm>
!     <primary><varname>search_path</varname></primary>
!     <secondary>run-time setting</secondary>
     </indexterm>
  
     <para>
diff --git a/doc/src/sgml/ref/create_function.sgml b/doc/src/sgml/ref/create_function.sgml
new file mode 100644
index 48160b2..1f6c134
*** a/doc/src/sgml/ref/create_function.sgml
--- b/doc/src/sgml/ref/create_function.sgml
*************** SELECT * FROM dup(42);
*** 674,680 ****
    <title>Writing <literal>SECURITY DEFINER</literal> Functions Safely</title>
  
    <indexterm>
!    <primary><varname>search_path</varname> configuration parameter</>
     <secondary>use in securing functions</>
    </indexterm>
  
--- 674,680 ----
    <title>Writing <literal>SECURITY DEFINER</literal> Functions Safely</title>
  
    <indexterm>
!    <primary><varname>search_path</varname></>
     <secondary>use in securing functions</>
    </indexterm>
  
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to