On 27 March 2013 17:50, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: > On 27.03.2013 19:34, Simon Riggs wrote: >> >> On 27 March 2013 16:24, Heikki Linnakangas<hlinnakan...@vmware.com> >> wrote: >>> >>> Lastly, it breaks the new pg_basebackup -R >>> >>> functionality; pg_basebackup will create the recovery.conf file, but it >>> won't take effect. >> >> >> AFAIK pg_basebackup doesn't backup files not in the data directory and >> tablespace dirs. > > > Imagine that you have set recovery_config_directory='/foo/' in the master > server. Now you want to set up a standby, so you do:' > > pg_basebackup -D data-standby -R > > With the -R option, pg_basebackup creates data-standby/recovery.conf to > point to the master, with standby_mode='on'. But if you start the server, it > will start up as a master, not as a standby, because > recovery_config_directory points elsewhere.
Yeh, I get it. Same argument applies to all conf files, not just recovery.conf. Sounds like the patch to add -R to pg_basebackup should be revoked as being not well thought out. Or it should be fixed, in which case this works the same. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
