On 27 March 2013 16:24, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: > On 27.03.2013 18:10, Simon Riggs wrote: >> >> On 27 March 2013 15:35, Heikki Linnakangas<hlinnakan...@vmware.com> >> wrote: >>> >>> Ok, cool. Can you please revert this commit so that we can move on, then? >> >> >> Please explain why you want this reverted, without mentioning the >> other task we agree is required. > > > If an admin can't trust that the file is placed in $PGDATA, it's harder to > determine if a server is a master or a standby. It makes tools that try to > promote / demote a server more complicated, because they need to take this > setting into account. Lastly, it breaks the new pg_basebackup -R > functionality; pg_basebackup will create the recovery.conf file, but it > won't take effect.
AFAIK pg_basebackup doesn't backup files not in the data directory and tablespace dirs. This doesn't change that. If it does, and I am mistaken, then it will be an easy fix. > From a process standpoint, this is a new feature that should've been > submitted before the commitfest deadline. I'm sure we'll make exceptions to > that every now and then, but by default new features should be bumped to the > next release at this point. I'm adding it by popular request, agreement and an explicit timing plan, all of which I followed. I didn't add this feature because I want it, and honestly, I don't really care about it myself, which is why I left it to last thing on my work schedule. But I do listen to requests from others, which is why I've spent close to 2 days of my time on it as part of my contribution to the team. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
