On Wed, May 15, 2013 at 4:46 PM, Jon Nelson <jnelson+pg...@jamponi.net> wrote:
> On Wed, May 15, 2013 at 4:34 PM, Andres Freund <and...@2ndquadrant.com> wrote:
>> Some where quick comments, without thinking about this:
> Thank you for the kind feedback.
>> * needs a configure check for posix_fallocate. The current version will
>>   e.g. fail to compile on windows or many other non linux systems. Check
>>   how its done for posix_fadvise.

The following patch includes the changes to configure.in.
I had to make other changes (not included here) because my local
system uses autoconf 2.69, but I did test this successfully.

> That's true. I originally wrote the patch using fallocate(2). What
> would be appropriate here? Should I switch on the return value and the
> six (6) or so relevant error codes?

I addressed this, hopefully in a reasonable way.


Attachment: fallocate.patch-v2
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to