Hi Andres, Attached is a patch which does not CREATE DATABASE, but now the regression tests do not test the following:
- ALTER DATABASE RENAME TO is not allowed on a database in use. Had to remove two tests that were using this. - ALTER DATABASE SET TABLESPACE is also not allowed on a database in use, so removed it (the existing test was supposed to fail too, but it was to fail at a later stage in the function when checking for whether the tablespace exists, but with the 'regression' database, it just doesn't even reach that part) - The CREATE DATABASE test itself was checking whether the 'CONNECTION LIMIT' was working. Removed that as well. Code coverage improved from 36% to 68%. -- Robins Tharakan On 24 June 2013 07:47, Andres Freund <and...@2ndquadrant.com> wrote: > On 2013-05-21 02:58:25 +0530, Robins Tharakan wrote: > > Attached is an updated patch that does only 1 CREATE DATABASE and reuses > > that for all other tests. > > The code-coverage with this patch goes up from 36% to 70%. > > Even creating one database seems superfluous. The plain CREATE DATABASE > has been tested due to the creation of the regression database itself > anyway? > All the other tests should be doable using the normal regression db? > > Greetings, > > Andres Freund > > -- > Andres Freund http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services >
regress_db_v4.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
