On Sat, Jun 29, 2013 at 11:24 AM, Robins <rob...@pobox.com> wrote: > On 10 June 2013 00:17, Jeff Davis <pg...@j-davis.com> wrote: >> >> On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote: >> > > Come to think of it, even without the torn page & checksum issue, do >> > > we >> > > really want to actively clear the all-visible flags after upgrade? >> >> Removed that from the patch and rebased. I think the best approach is to >> remove the bit opportunistically when we're already dirtying the page >> for something else. >> >> However, right now, there is enough skepticism of the general approach >> in this patch (and enough related proposals) that I'll leave this to be >> resolved if and when there is more agreement that my approach is a good >> one. >> > > Did some basic checks on this patch. List-wise feedback below. > > - Cleanly applies to Git-Head: Yes (Some offsets, but thats probably because > of delay in review) > - Documentation Updated: No. (Required?) > - Tests Updated: No. (Required?) > - All tests pass: Yes > - Does it Work : ??? > > - Any visible issues: No > - Any compiler warnings: No > > - Others: > Number of uncovered lines: Reduced by 167 lines
I thought that Jeff withdrew this patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
