On 2013-11-20 17:46:22 +0100, Andres Freund wrote: > On 2013-11-20 18:25:56 +0200, Heikki Linnakangas wrote: > > Isn't it possible that the standby has already incorrectly set > > HEAP_XMIN_INVALID hint bit on a page? The full page images generated by > > VACUUM FREEZE will correct the damage, but if not, e.g. because > > full_page_writes=off, strange things will happen. > > The xlog_heap_freeze records should repair that afaics.
Nope, it wouldn't, it just uses heap_freeze_tuple() again which *only* sets HEAP_XMIN_COMMITTED but does *not* clear HEAP_XMIN_INVALID. And if we were to change that now, it wouldn't help already frozen tuples that wouldn't get frozen again. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
