On 27 November 2013 10:35 Fujii Masao wrote: > On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi > <haribabu.ko...@huawei.com> wrote: > > On 26 November 2013 23:11 Fujii Masao wrote: > >> On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi > >> <haribabu.ko...@huawei.com> wrote: > >> > I tried using of stat'ing in two directories, which is having a > >> problem in windows. > >> > So modified old approach to detect limited errors. Updated patch > >> attached. > >> > This will detect and throw an error in the following scenarios. > >> > 1. pg_basebackup -D /home/data --xlogdir=/home/data 2. > >> > pg_basebackup -D data --xlogdir=/home/data -- home is the CWD 3. > >> > pg_basebackup -D ../data --xlogdir=/data -- home is the CWD > >> > > >> > Please let me know your suggestions. > >> > >> Checking only #1 and #2 cases looks sufficient to at least me. If we > >> do that, we can refactor the patch so that it reuses > >> make_absolute_path() instead of adding new functions, as pointed in > >> upthread. Anyway, what about committing the core patch (Updated > >> version of core patch attached) first? Then, we can discuss the > check logic more. > > > > Yes it is fine. The core patch attached in the mail is working fine. > > Okay. Committed!
Thanks. Regarding refactoring the code to use make_absolute_path for checking the data and xlog directories are same or not, this function exists in two places 1. pg_regress.c 2.miscinit.c. Solution -1: if we move the backend function to path.c, it cannot use the ereport Functions. So it may cause problem to backends. Solution -2: Rename the backend function as make_absolute_path_internal and add a New function to the path.c Please let me know your opinion on the same or is there anything I missed? Regards, Hari babu. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
