On 2014-02-12 19:13:07 +0100, Marco Atzeri wrote: > On 12/02/2014 17:26, Tom Lane wrote: > >Hm. So if we're giving up on the idea of ever getting rid of PGDLLIMPORT, > >we ought to actually remove that, so that the Cygwin build works more like > >the other Windows builds?
> If I am not wrong "--enable-auto-import" is already the > default on cygwin build chain ( binutils >= 2.19.51 ) so it should make no > difference on latest cygwin. Not sure for you 1.7.7 build enviroment. We're *disabling* not *enabling* it. > About PGDLLIMPORT , my build log is full of "warning: ‘optarg’ redeclared > without dllimport attribute: previous dllimport ignored " That should be fixed then. I guess cygwin's getopt.h declares it that way? > I suspect that removing will also make no difference. The committed patch explicitly disables the functionality. > PS: we aim unix-like builds not windows one.... Well, there are a significant number of caveats around the auto import functionality, so there seems little benefit in using it if all the declspec's have to be there anyway. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers