On 2014-03-13 17:00:33 -0400, Andrew Dunstan wrote:
> Peter Geoghegan has been doing a lot of great cleanup of the jsonb code,
> after moving in the bits we wanted from nested hstore. You can see the
> current state of the code at
> <https://github.com/feodor/postgres/tree/jsonb_and_hstore>

I've pushed one commit with minor fixes, and one with several FIXMEs to

The most imortant things are:

* Jsonb vs JsonbValue is just bad, the latter needs to be renamed, and
  there needs to be a very clear explanation about why two forms exist
  and what each is used for.
* The whole datastructure doesn't have any sensible highlevel
* I don't really like the JsonbSuperHeader name/abstraction. What does
  the "Super" mean? The only interpetation I see is that it's the
  toplevel header (why not Top then?), but JEntry has the comment: "/*
  May be accessed as superheader */"...


Andres Freund

 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to