Hi, On 2014-04-03 12:47:00 +0200, Andres Freund wrote: > The current quiet inline test doesn't work for clang. As e.g. evidenced in > http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gull&dt=2014-04-03%2007%3A49%3A26&stg=configure > configure thinks it's not quiet. > > Which means that postgres compiled with a recent clang will be noticably > slower than it needs to be. > > The reason for that is that clang is smart and warns about static inline > if they are declared locally in the .c file, but not if they are > declared in a #included file. That seems to be a reasonable > behaviour... > > I think that needs to be fixed. We either can make the configure test > considerably more complex or simply drop the requirement for quiet > inline.
I still think we really need to fix this. I have three possible solutions: a) Add an external file (in the source tree) that's included in the configure test. b) Have a compiler specific override and specify USE_INLINE there. c) Drop the requirement of quiet inlines. a) would probably the best, but I haven't yet found a non ugly solution :( Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
