Hi Palle, thanks for the extremely quick response!
In that case I will include the patch in Postgres.app. Missing support for per-column collations is preferable to missing support for the standard locale! I'll have a look at the per-column collation support, it would be great if PostgreSQL on OS X would work out of the box at some point. Best regards, Jakob > Am 26.11.2014 um 08:41 schrieb Palle Girgensohn <gir...@pingpong.net>: > > Hi! > > This is indeed a very well tested patch as we've run it in production for 8+ > years on 20+ systems. > > It is not included upstreams mainly because I did ask for it to happen. I've > been aiming to do it but haven't got around to it. Also, since 9.2 (?) there > is support in PostgreSQL for setting collate locale per column. This is not > yet supported by the patch, which makes it non-complete. You could argue that > this is not as important as supporting the primary locale, but it would be > hard to argue about that, it would have to be added for it to reach inclusion > upstreams. > > So, I can vouch for it, it does the job just fine. Upstreams support will > happen eventually. > > Palle > > > > 26 nov 2014 kl. 08yt:31 skrev Jakob Egger <ja...@eggerapps.at > <mailto:ja...@eggerapps.at>>: > >> When packaging PostgreSQL for Postgres.app, I discovered a problem: strcoll >> doesn't work for multibyte encodings on OS X. As a consequence, text sorting >> in PostgreSQL doesn't work. The only workaround seemed to be to use a legacy >> encoding like latin1, which is inacceptable. >> >> I discovered that OS X shares this limitation with FreeBSD, and there exists >> a patch written by Palle Girgensohn that uses the ICU library for collating >> strings instead of the std-c strcoll function. You can find it at >> http://people.freebsd.org/~girgen/postgresql-icu/README.html >> <http://people.freebsd.org/~girgen/postgresql-icu/README.html> >> >> I applied the patch, and according to preliminary testing with 9.4rc1 it >> seems to work flawlessly on OS X as well. >> See https://github.com/PostgresApp/PostgresApp/releases/tag/9.4rc1 >> <https://github.com/PostgresApp/PostgresApp/releases/tag/9.4rc1> >> >> I have two questions: >> >> 1) Does anybody else have experience with this patch? Is it safe to release >> PostgreSQL binaries with this patch applied to the public? >> >> 2) Is there a reason why this patch hasn't been merged into core over the >> years? Since it requires setting a configure switch (--with-icu) it >> shouldn't break anything? >> >> Best regards, >> Jakob Egger >> >>
