On 2015-09-02 17:27:38 +0200, Andres Freund wrote: > 1) Passing the list of parents through the cascade DefElem strikes me as > incredibly ugly. > > For one the cascade option really should take a true/false type option > on the C level (so you can do defGetBoolean()), for another passing > through the list of parents via DefElem->arg seems wrong. You're > supposed to be able to copy parsenodes and at the very least that's > broken by the approach.
I think the fix here is to split off the bulk of CreateExtension() into an internal function that takes additional parameters. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
