On 2015-09-07 20:56:50 +0200, Petr Jelinek wrote: > Yes that sounds cleaner. Just as a side note, List is a Node and does have > copy support (and we pass List as DefElem->arg from gram.y in several > places).
I know - but the list element in this case don't have copy support, no? You seem to have put plain C strings in there, right? > > 2) I don't like the control flow around the schema selection. > > > > It seems to be getting a bit arcane. How about instead moving the > > "extension \"%s\" must be installed in schema \"%s\" check into the if > > (control->schema != NULL) block and check for d_schema after it? That > > should look cleaner. > > > > I did something like that in one of the revisions, the complaint there was > that it changes order of errors you get in situation when the schema is not > the same as the one in control file and it also does not exist. So what? That seems like a pretty harmless change - it's not like this is something being hit day in/out right now. Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
