On 2 November 2015 at 20:35, Andres Freund <and...@anarazel.de> wrote: > On 2015-11-02 20:17:21 +0800, Craig Ringer wrote: > >> See the README.md and DESIGN.md in the attached patch for details on >> the plugin. I will follow up with a summary in a separate mail, along >> with a few points I'd value input on or want to focus discussion on. > > Sounds to me like at least a portion of this should be in sgml, either > in a separate contrib page or in the logical decoding section.
Yes, I think so. Before rewriting to SGML I wanted to solicit opinions on what should be hidden away in a for-developers README file and what parts deserve exposure in the public docs. > A quick readthrough didn't have a separate description of the > "sub-protocol" in which changes and such are encoded - I think we're > going to need that. It didn't quite make the first cut as I have to make a couple of edits to reflect late changes. I should be able to follow up with that later today. The protocol design documentation actually predates the plugin its self, though it saw a few changes where it became clear something wouldn't work as envisioned. It's been quite a pleasure starting with a detailed design, then implementing it. > There's a bunch of changes that are hinted at in the files in various > places. Could you extract the ones you think need to be fixed before > integration see in some central place (or just an email)? Yep, writing that up at the moment. I didn't want to make the initial post too verbose. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers