My +1 for moving function to xlogutils.c too. Now call to this function goes through series of callbacks so it is hard to find it. Personally I found it only after I have implemented same function by myself (based on code in pg_xlogdump).
Stas Kelvich Postgres Professional: http://www.postgrespro.com The Russian Postgres Company > On 12 Jan 2016, at 18:56, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Michael Paquier wrote: >> On Tue, Jan 12, 2016 at 5:21 PM, Simon Riggs <si...@2ndquadrant.com> wrote: >>> Should we just move the code somewhere just to imply it is generic? Seems >>> pointless refactoring to me. >> >> Er, why not xlogutils.c? Having the 2PC code depending directly on >> something that is within logicalfuncs.c is weird. > > Yes, I agree with Michael -- it's better to place code in its logical > location than keep it somewhere else just because historically it was > there. That way, future coders can find the function more easily. > > -- > Álvaro Herrera http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > > > -- > Sent via pgsql-hackers mailing list (email@example.com) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers