Roma Sokolov wrote:
See v2 of the patch attached.


Hello.
I have a stylistic comments. Sometimes you forget a space:
+  replaces[Anum_pg_operator_oprcom - 1] =true;

or use tab insted space:
+       if (OidIsValid(op->oprnegate) ||
+               (OidIsValid(op->oprcom)      && operOid != op->oprcom))
+               OperatorUpd(operOid,
+                                       operOid == op->oprcom ?      InvalidOid : 
op->oprcom,
+                                       op->oprnegate,
+                                       true);

And I think if you make this logic into a separate function,
it is possible to simplify the code. OperatorUpd function is too complex.

Also better to add comments to the tests.
The rest seems good.

PS I here thought it would be possible to print operators that have been changed?

--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to