On 2016/04/20 16:20, Etsuro Fujita wrote:
> On 2016/04/18 17:31, Amit Langote wrote:
>> Is the following description now outdated:
>> "ForeignPath represents a potential scan of a foreign table"
>> Considering that there now exists FdwRoutine.GetForeignJoinPaths() whose
>> product is nothing else but a ForeignPath, should it now say (patch
>> "ForeignPath represents a potential scan of foreign table(s)"
>> Or something better.
> I think it'd be better to match the comment with that for
> create_foreignscan_path(). So how about "ForeignPath represents a
> potential scan of a foreign table, foreign join, or foreign upper-relation
> processing"? I think we would probably need to update the comment in
> src/backend/optimizer/README (L358), too.
That's a lot better. Updated patch attached.
diff --git a/src/backend/optimizer/README b/src/backend/optimizer/README
index 5e12459..2407172 100644
@@ -355,7 +355,7 @@ RelOptInfo - a relation or joined relations
BitmapHeapPath - top of a bitmapped index scan
TidPath - scan by CTID
SubqueryScanPath - scan a subquery-in-FROM
- ForeignPath - scan a foreign table
+ ForeignPath - scan a foreign table, foreign join or foreign upper-relation
CustomPath - for custom scan providers
AppendPath - append multiple subpaths together
MergeAppendPath - merge multiple subpaths, preserving their common sort order
diff --git a/src/include/nodes/relation.h b/src/include/nodes/relation.h
index e9dfb66..45739c3 100644
@@ -1030,7 +1030,8 @@ typedef struct SubqueryScanPath
- * ForeignPath represents a potential scan of a foreign table
+ * ForeignPath represents a potential scan of a foreign table, foreign join
+ * or foreign upper-relation.
* fdw_private stores FDW private data about the scan. While fdw_private is
* not actually touched by the core code during normal operations, it's
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: